Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IPAM] support additional pools #2830

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[IPAM] support additional pools #2830

merged 1 commit into from
Dec 3, 2024

Conversation

fra98
Copy link
Member

@fra98 fra98 commented Nov 22, 2024

Description

This PR adds the support for additional pools in the new IPAM

@fra98 fra98 added the kind/feature New feature or request label Nov 22, 2024
@adamjensenbot
Copy link
Collaborator

Hi @fra98. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@fra98 fra98 force-pushed the frt/ipam-additional-pools branch from 67e4f3e to 3b2993d Compare November 25, 2024 15:17
@pull-request-size pull-request-size bot added size/S and removed size/M labels Nov 25, 2024
@fra98 fra98 force-pushed the frt/ipam-additional-pools branch 4 times, most recently from 05a9590 to f6db0e0 Compare December 2, 2024 10:22
@fra98 fra98 force-pushed the frt/ipam-additional-pools branch 2 times, most recently from 589044b to db3ed5a Compare December 2, 2024 11:33
@fra98 fra98 marked this pull request as ready for review December 2, 2024 11:33
aleoli
aleoli approved these changes Dec 3, 2024
View reviewed changes
deployments/liqo/values.yaml Outdated Show resolved Hide resolved
@fra98 fra98 force-pushed the frt/ipam-additional-pools branch from 35f55fb to a738cd6 Compare December 3, 2024 10:45
@fra98 fra98 merged commit 23c05a7 into liqotech:ipam Dec 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@cheina97 cheina97 Awaiting requested review from cheina97

@claudiolor claudiolor Awaiting requested review from claudiolor

Assignees
No one assigned
Labels
kind/feature New feature or request size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fra98 @adamjensenbot @aleoli